8.0.0-preview.6.23320.3<

interesting, @geeknoid changes already published to NuGet?

If this is from the main branch, then everything's set up correctly in this PR. All we'll need is to add a subscription from extensions into this repo. The only issue there is it creates a circular dependency between this repo and extensions, which can be a problem for product construction. I think it'll be fine if we set up the extensions -> aspnetcore sub to be everyWeek frequency - @mmitche to confirm

You beat me to it :P, I was about to ask about the circular dependency for this. Keep in mind this dependency is for use in tests only, so I think that in the case that darc doesn't allow to setup this subscription could go with two options:

• Either add support in dependency flow for test-only dependencies (similar to how we have special case for tooling today) so we can introduce ciruclar dependencies on these cases, or
• Not use dependency flow for test-only dependencies that could introduce ciruclar dependencies for repos. If we go with that plan, then we undo the change to this Version.Details.xml file and we just update the version we depend on in a as-needed basis.

Or C: Do not allow circular dependencies.

Circular dependencies are allowed for testing purposes. However, this must be moved to the ToolsetDependencies section otherwise the product is incoherent and cannot be shipped. What this means is:

• dotnet/extensions outputs will not show in the build drop.
• dotnet/extensions outputs is not part of the main SDK-umbrella product.

It's my understanding that this is the intention. If it's not, then we have a product layering issue, or we need to change how we prep the product for shipping. As usual, that would make me question why we have a separate repo for these things in the first place.

Yup, the intention is for this to be test-only and shouldn't be in the build drop nor part of the main SDK product. @mmitche so is the concrete feedback then that we should move these 4 lines on this file down to <ToolsetDependencies> section (line 360), and then that should allow us to setup darc subscription correctly? Or is there something else that needs to be done to setup the darc subscription?

@JamesNK @joperezr let me know if you need my help setting up the subscription

Yes please.

Note: The InstrumentRecorder has just been removed from runtime (for this preview) so this PR needs to make it in, otherwise we'll be blocked when consuming runtime updates.

dotnet/runtime#87873

I've just woken up and have meetings for the next couple of hours 😬

To confirm, this dependency needs to be moved to Toolset before this gets checked in.

Subscription created

https://github.com/dotnet/extensions (.NET 8) ==> 'https://github.com/dotnet/aspnetcore' ('main')
  - Id: ba55bbf2-4239-468a-a9c6-08db6772cb2c
  - Update Frequency: EveryWeek
  - Enabled: True
  - Batchable: False
  - PR Failure Notification tags: 
  - Merge Policies:
    AllChecksSuccessful
      ignoreChecks = 
                       [
                         "aspnetcore-quarantined-pr",
                         "aspnetcore-quarantined-pr (Tests: Helix),",
                         "aspnetcore-quarantined-pr (Tests: macOS),",
                         "aspnetcore-quarantined-pr (Tests: Ubuntu x64),",
                         "aspnetcore-quarantined-pr (Tests: Windows x64)"
                       ]
    NoRequestedChanges

To confirm, this dependency needs to be moved to Toolset before this gets checked in.

Moved dependency to toolset.